From a2cc7bbd08915803a684e4d6e9db5eb6ad2ae57a Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 24 Sep 2026 10:01:36 +0000 Subject: [PATCH] i18n: say only what was observed about the leaked JVM default locale Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01Uu7q8vPeREyT4218EJPzz1 --- i18n/README.md | 2 +- .../test/java/com/ankurm/i18n/SystemLocaleFallbackTests.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/i18n/README.md b/i18n/README.md index faad234..b2a036c 100644 --- a/i18n/README.md +++ b/i18n/README.md @@ -29,7 +29,7 @@ mvn test # runs every scenario and rewrites output/01-11 The tests pin the JVM to `-Duser.language=en -Duser.country=US -Dfile.encoding=UTF-8` (see `pom.xml`) so the transcripts do not depend on the machine they were generated on, and run each test class in its own JVM -(`reuseForks=false`) because Tomcat reads the JVM's default locale once. +(`reuseForks=false`) because a test that changes the JVM's default locale once leaked it into another test's transcript. ## Profiles diff --git a/i18n/src/test/java/com/ankurm/i18n/SystemLocaleFallbackTests.java b/i18n/src/test/java/com/ankurm/i18n/SystemLocaleFallbackTests.java index 4f475e9..3c24b96 100644 --- a/i18n/src/test/java/com/ankurm/i18n/SystemLocaleFallbackTests.java +++ b/i18n/src/test/java/com/ankurm/i18n/SystemLocaleFallbackTests.java @@ -7,8 +7,8 @@ import java.util.Locale; import static org.assertj.core.api.Assertions.assertThat; /** - * Transcript 02. Changes the JVM's default locale, and Tomcat reads that default once per JVM, so this class runs in its own - * JVM (surefire reuseForks=false) and cannot leak a Hindi default into the "no Accept-Language header" row of transcript 01. + * Transcript 02. Changes the JVM's default locale. In an earlier run a Hindi default set here leaked into the + * "no Accept-Language header" row of transcript 01, so this class runs in its own JVM (surefire reuseForks=false). */ class SystemLocaleFallbackTests {